stadiamaps / ferrostar

A FOSS navigation SDK built from the ground up for the future
https://stadiamaps.github.io/ferrostar/
Other
180 stars 25 forks source link

Fix issue with expanded full screen layout for instructions #350

Closed ianthetechie closed 2 weeks ago

ianthetechie commented 2 weeks ago

I'm not quite sure how this got past my testing, but there was something wrong with the layout in the last release, either as a result of complex interaction or perhaps because of how I did the lazy column the first time around. I still don't fully understand why, but even debugging the layout inspector live, the previous iteration would "push" the pill offscreen at which point it was dropped from the composable completely if the list of instructions were long!

Colllapsed:

image

Expanded (large):

image

Detail showing the layout inspector to show how the pill is carefully aligned:

image