Closed nyurik closed 10 months ago
P.S. My fmmap PR was merged (impressive speed!), but i'm still a bit concerned - that repo is not often maintained, whereas https://github.com/RazrFalcon/memmap2-rs seems to be the latest "standard" in the memmap crates. Is there a reason for fmmap?
The simple answer about the mmap library is async support @nyurik. It doesn't look like memmap2 supports async, and I didn't want to litter the library with block_in_place calls.
Looks good once tests pass. 👍
I'll wait for a day or two to see if fmmap is released - feels kinda bad to use an unreleased dependency
thiserror
for all errors to allow better error reportingfmmap
has not been updated for a long time, and because of that it no longer compiles in some cases because of the dependency problems. I submitted a PR, hopefully will be merged/published soonish.