stadiamaps / pmtiles-rs

Rust implementation of PMTiles
Apache License 2.0
52 stars 8 forks source link

Make features explicit, error fixes, #19

Closed nyurik closed 10 months ago

nyurik commented 10 months ago
nyurik commented 10 months ago

P.S. My fmmap PR was merged (impressive speed!), but i'm still a bit concerned - that repo is not often maintained, whereas https://github.com/RazrFalcon/memmap2-rs seems to be the latest "standard" in the memmap crates. Is there a reason for fmmap?

lseelenbinder commented 10 months ago

The simple answer about the mmap library is async support @nyurik. It doesn't look like memmap2 supports async, and I didn't want to litter the library with block_in_place calls.

lseelenbinder commented 10 months ago

Looks good once tests pass. 👍

nyurik commented 10 months ago

I'll wait for a day or two to see if fmmap is released - feels kinda bad to use an unreleased dependency