search

stadlar / IST-FUT-FMTH

Creative Commons Attribution 4.0 International
12 stars 19 forks source link

Claims - BatchId in ClaimTransaction #173

Closed danielsveins closed 1 year ago

danielsveins commented 1 year ago

claimTransaction has the property batchId. According to the current definition of IOBWS-Claims3.0.yaml this is the Id of the claim batch. The same Id is used in /v1/batches/{batchId} for example.

I assume this is supposed to be the Id of the payment batch, as is the case in IOBWS 2.0. If so then it would be ideal to define a new property which indicates that clearly, i.e. paymentBatchId.

danielsveins commented 1 year ago

The name batchNumber is used in IOBWS 2.0. Would the "Number" postfix be preferred to "Id"?

kristinnstefansson commented 1 year ago

The batchID seems to correspond to the older 162:2013 "Bunkanúmer greiðslu", which would be a 4 char indicator that is fast becoming obsolete. Instead a unique payment ID would be a future improvement, when that becomes possible. Having the "redeemingBank" on hand with the BatchID of the Payment can help with tracing issues but is dependant on it being available.

The suggestion from meeting TN-FMÞ-VH7-16 is to rename "redeemingbank" to transactionBank and BatchId to transactionBatchID. The descriptions might also include further context.

Kristinn-Stefansson commented 1 year ago

Approved according to agreement on TN-FMÞ-VH7-18 and PR merged