search

stadlar / IST-FUT-FMTH

Creative Commons Attribution 4.0 International
12 stars 19 forks source link

Claims - Use different schemas for batch initiation #181

Closed haukurhrafn closed 1 year ago

haukurhrafn commented 1 year ago

Use different schemas for batch initiation payload to indicate intended action type.

171

asgeirhall commented 1 year ago

Quick question why did you change the action type from alter to merge?

I think we spoke quite alot about using same naming as RB, Create, Alter, Cancel claims

haukurhrafn commented 1 year ago

Quick question why did you change the action type from alter to merge?

I think we spoke quite alot about using same naming as RB, Create, Alter, Cancel claims

Good catch. The request objects for patching a single claim and posting a batch were already named merge so I thought the action type naming should match.

I'd be happy to submit a commit that reverts that change if it's an issue that the committee already reached a conclusion on.