search

stadlar / IST-FUT-FMTH

Creative Commons Attribution 4.0 International
12 stars 19 forks source link

Changed all amount properties that were defined as integers to numbers #182

Closed danielsveins closed 1 year ago

danielsveins commented 1 year ago

All amount properties that were defined as integers in IOBWS-Claims3.0.yaml have been changed to number.

166

asgeirh commented 1 year ago

Just a quick question, I know the reason for these numbers to be integers is because to my knowledge the banks don't support non integer numbers in those fields, Some banks even return errors if you send 10,00 and only allow 10.

How would the banks handle for example if we would send in 10,5 in amount?

But the percentage for interest needs to support decimal numbers. As Interest is not often whole numbers.

On Fri, May 12, 2023 at 3:37 PM Daníel Sveinsson @.***> wrote:

All amount properties that were defined as integers in IOBWS-Claims3.0.yaml https://github.com/stadlar/IST-FUT-FMTH/blob/master/Deliverables/IOBWS-Claims3.0.yaml have been changed to number.

166 https://github.com/stadlar/IST-FUT-FMTH/issues/166

You can view, comment on, or merge this pull request online at:

https://github.com/stadlar/IST-FUT-FMTH/pull/182 Commit Summary

File Changes

(1 file https://github.com/stadlar/IST-FUT-FMTH/pull/182/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/stadlar/IST-FUT-FMTH/pull/182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4UIWV3UO2DLV5XBBW6EDXFZKKHANCNFSM6AAAAAAX7WDQN4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Regards, Asgeir Halldorsson