search

stadlar / IST-FUT-FMTH

Creative Commons Attribution 4.0 International
12 stars 19 forks source link

Claims - Unnecessary properties in default interests #195

Closed danielsveins closed 1 year ago

danielsveins commented 1 year ago

The defaultInterest entity has some unnecessary properties, they are enums with only one option which are all required at RB, giving the consumer merely the illusion of choice.

The properties in question are calculationPeriod, calculationDayRule and defaultInterestException.

I suggest to remove these properties from IOBWS 3.0.

kristinnstefansson commented 1 year ago

Meeting TN-FMÞ-VH7-18 looked at the core system documentation that showed that the given properties only have a single available choice for enum, CalculationPeriod has [24-24], CalculationDayRule has [PaymentDay] and DefaultInterestException has [NoException]. The banks will take a notice of this, look into if this should be skipped in the creation but necessary in views or can be skipped altogether. It turned out however that the template/auðkenni/vísir has the possibility to switch settings that determine the due date and that should be the place for variations, not in the creation of the claim. These properties should not be on create and alter.

Kristinn-Stefansson commented 1 year ago

Marked as processed in line with agreement on TN-FMÞ-VH7-18 and PR