search

stadtnavi / digitransit-ansible

Ansible setup for Digitransit platform
7 stars 5 forks source link

No deployment specific parameters in group_vars/all.yml #1

Closed hbruch closed 4 years ago

hbruch commented 4 years ago

user/certbot_admin_email will be deployment specific vars. They should be extracted from group_vars/all.yml

hbruch commented 4 years ago

The same applies for docker-compose.yml: specific settings like router/images should be extracted

leonardehrenfried commented 4 years ago

user/certbot_admin_email will be deployment specific vars. They should be extracted from group_vars/all.yml

Ok, this has been fixed in https://github.com/mfdz/digitransit-ansible/commit/ec3d93e332d2916b34a8e775ffb9f140ecb07c87

leonardehrenfried commented 4 years ago

The same applies for docker-compose.yml: specific settings like router/images should be extracted

So all the image names should move into variables?

leonardehrenfried commented 4 years ago

I've extracted a lot of variables including the docker image names.