Upstream construction works in tilemaker

leonardehrenfried commented 4 years ago

Beki has sucessfully added the construction works to our map tiles. We would like the changes to process-openmaptiles.lua to be upstreamed to https://github.com/systemed/tilemaker/blob/master/resources/process-openmaptiles.lua

Note that since I took a copy of this file it has changed a bit so you cannot just copy our file back.

Acceptance criteria

Do a bit more QA by checking other construction sites in BaWü (https://github.com/systemed/tilemaker/blob/master/resources/process-openmaptiles.lua) and make sure they are rendered on our map correctly
Take the construction works and copy them upstream
If it becomes too difficult to just upstream, you can copy their file into our repo, add the construction back in and the upstream that.

meromisi commented 4 years ago

Is it a problem that constructions only appear above an exact zoom level(13)? (same like small roads)

leonardehrenfried commented 4 years ago

I think that it's ok.

leonardehrenfried commented 4 years ago

Oh, and when you open the PR upstream, it's always a good idea to add before-and-after screenshots. It's probably enough to link to this ticket: https://github.com/stadtnavi/digitransit-ansible/issues/24

leonardehrenfried commented 4 years ago

Another thought: just ask upstream what they think about the zoom. I'd be fine either way.

meromisi commented 4 years ago

He has merged it already.