search

stadtnavi / digitransit-ui

Digitransit UI Clone, especially for the city of Herrenberg ("stadtnavi.de")
https://stadtnavi.de/
Other
13 stars 14 forks source link

Prettify popups (again) #373

Closed leonardehrenfried closed 3 years ago

leonardehrenfried commented 3 years ago

Since I merged with upstream again many popups look broken. Presumably this is because some CSS changed upstream.

Cycle infrastructure

Screenshot from 2021-04-28 13-14-57 Screenshot from 2021-04-28 13-14-31

Car parks

Not quite as bad.

Screenshot from 2021-04-28 17-20-56 Screenshot from 2021-04-28 17-20-26

Public toilets

Screenshot from 2021-04-28 17-24-19

Weather stations

Screenshot from 2021-04-29 14-53-10

aaronyamil commented 3 years ago

Hi @Denis306, Leonard comment the following in the pull request: https://github.com/stadtnavi/digitransit-ui/pull/382#issuecomment-831071812

I think we need of Sandra, because the popups will be prettify. this ticket is not just fix the styles, needs a new design more nice.

Denis306 commented 3 years ago

Hi @aaronyamil yes, we are aware of this. Sandra is already working on the proposal for the design changes. Depending on the decision/priorization we will do work on the pop-ups or panels so that it is consistent in mobile and web view.

leonardehrenfried commented 3 years ago

Would I nevertheless be possible to fix the margins in the meantime so the app looks less broken?

aaronyamil commented 3 years ago

Sure!.. I will review my changes and fix the margins. Meanwhile Sandra works in the new design.

aaronyamil commented 3 years ago

@leonardehrenfried I created another pullrequest more clean: https://github.com/stadtnavi/digitransit-ui/pull/402

For this reason I closed this.

aaronyamil commented 3 years ago

Status: I removed the middle button. I fixed the margins problems. I am working with the icon parking.