search

stadtnavi / digitransit-ui

Digitransit UI Clone, especially for the city of Herrenberg ("stadtnavi.de")
https://stadtnavi.de/
Other
13 stars 14 forks source link

Disabled floating vehicles should not be drawn on map #782

Open hbruch opened 2 years ago

hbruch commented 2 years ago

Current behavior: In case a free floating vehicle has is_disabled: true set, it is rendered with icon-icon_xxx_station_closed_xxx:

grafik

Expected behavior: In case a free floating vehicle has is_disabled: true set, it should not be rendered on the map.

hbruch commented 2 years ago

Commit https://github.com/mfdz/OpenTripPlanner/commit/71c791041962949aa419d011d5f367fd4b3b2358 returns disabled floating vehiceles with state "Station off". The API currently does not return, if the rental place is a station or a vehicle. While it makes sense to show a closed station in the map, disabled vehicles probably should not be rendered.

IMHO, either, for free floating vehicles state should be changed to "Vehicle available" "Vehicle not available", or a new new property e.g. type='station‘ or 'vehicle' be introduced.