search

stadust / pointercrate

Rewrite of the https://pointercrate.com backend in Rust
MIT License
80 stars 52 forks source link

Pagination cleanup #107

Closed stadust closed 5 months ago

stadust commented 6 months ago

An attempt at cleaning up pointercrate's horrible pagination code. The end goal here is to eliminate the pagination_response! macro.

License Acceptance

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 62.60163% with 138 lines in your changes are missing coverage. Please review.

Project coverage is 24.18%. Comparing base (576a2f0) to head (3598209).

Files Patch % Lines
pointercrate-demonlist/src/player/paginate.rs 39.02% 25 Missing :warning:
pointercrate-demonlist/src/submitter/paginate.rs 0.00% 21 Missing :warning:
pointercrate-demonlist/src/demon/paginate.rs 51.35% 18 Missing :warning:
...ointercrate-demonlist/src/player/claim/paginate.rs 0.00% 18 Missing :warning:
pointercrate-user/src/paginate.rs 0.00% 18 Missing :warning:
pointercrate-core-api/src/pagination.rs 86.66% 14 Missing :warning:
pointercrate-demonlist-api/src/endpoints/player.rs 20.00% 8 Missing :warning:
pointercrate-demonlist-api/src/endpoints/demon.rs 44.44% 5 Missing :warning:
pointercrate-core/src/pagination.rs 94.52% 4 Missing :warning:
...ntercrate-demonlist-api/src/endpoints/submitter.rs 0.00% 4 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #107 +/- ## ========================================== + Coverage 21.84% 24.18% +2.33% ========================================== Files 111 113 +2 Lines 8294 8447 +153 ========================================== + Hits 1812 2043 +231 + Misses 6482 6404 -78 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.