stadust / pointercrate

Rewrite of the https://pointercrate.com backend in Rust
MIT License
73 stars 46 forks source link

Better footer text #120

Closed exsii closed 2 months ago

exsii commented 3 months ago

font is .75em instead of .5em + tos's text width is increased to 35%

License Acceptance

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.32%. Comparing base (8965aa1) to head (aa04b0f). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #120 +/- ## ========================================== + Coverage 24.02% 24.32% +0.30% ========================================== Files 113 113 Lines 8421 8436 +15 ========================================== + Hits 2023 2052 +29 + Misses 6398 6384 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

exsii commented 3 months ago

forgot i should do that as well

stadust commented 2 months ago

Could you put some screenshots of how this looks on both mobile and desktop?

exsii commented 2 months ago

image image pc, 1 is current 2 is new

exsii commented 2 months ago

image image mobile, 1 is current 2 is new

stadust commented 2 months ago

Mh, yeah, definitely an improvement, thanks!

If it's easy, could you update the footer to only be a single column on mobile? It looks a bit wack both on the before and after screenshot, haha (if not, no worries, happy to merge as is, too)

exsii commented 2 months ago

should only require increasing min-width to 250px from 150 image

exsii commented 2 months ago

though 250px makes the divs too distanced from each other on pc so i used 200, looks pretty good as well image

exsii commented 2 months ago

should work now

stadust commented 2 months ago

Thanks!