stats viewer names not updating when clicking on others

stadust / pointercrate

Rewrite of the https://pointercrate.com backend in Rust

MIT License

80 stars 52 forks source link

stats viewer names not updating when clicking on others #34

Closed ghost closed 4 years ago

ghost commented 4 years ago

this seems to occur when clicking on names with no nationality, the name and nationality remain as those of the previous person (or blank if no one was selected prior)

stadust commented 4 years ago

Hi!

I for some reason have not received an e-mail about this, so sorry for my delayed response :( Thanks for bringing this to my attention though!

This must be related to all the changes to the JS code I did in march, I'll work on fixing it this evening.

qimiko commented 4 years ago

Since this doesn't seem fixed yet - Replace .innerHTML with .textContent in https://github.com/stadust/pointercrate/blob/fdfd7140aed2a20894ef526af820dedf4991378b/static2/js/modules/demonlist.mjs#L109

stadust commented 4 years ago

Looks reasonable, PR? :D

I'm drowning in classwork rn >.>