search

stadust / pointercrate

Rewrite of the https://pointercrate.com backend in Rust
MIT License
80 stars 52 forks source link

Cleanup GD integration code #97

Closed stadust closed 6 months ago

stadust commented 6 months ago

GD integration code in pointercrate has always been utter crap, so let's try to tidy it up at least a tiny bit. We drop all unnecessary caching concepts and only focus on (1) getting the data for listed demons, and (2) storing that in our database (in a still fairly insane way).

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 11.97605% with 147 lines in your changes are missing coverage. Please review.

Project coverage is 21.72%. Comparing base (043e8a9) to head (11aa7f9).

:exclamation: Current head 11aa7f9 differs from pull request most recent head cfc4208. Consider uploading reports for the commit cfc4208 to get more accurate results

Files Patch % Lines
pointercrate-integrate/src/gd.rs 4.42% 108 Missing :warning:
pointercrate-demonlist-pages/src/demon_page.rs 0.00% 37 Missing :warning:
pointercrate-demonlist-api/src/pages.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #97 +/- ## ========================================== + Coverage 20.82% 21.72% +0.89% ========================================== Files 110 110 Lines 8624 8309 -315 ========================================== + Hits 1796 1805 +9 + Misses 6828 6504 -324 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.