Irrelevant datasource name in some templates?

staempfli / magento2-code-generator

Code generator for Magento 2

250 stars 58 forks source link

Closed rev42 closed 7 years ago

rev42 commented 7 years ago

I found some irrelevant datasource names.

Is it intended to prepend them with "computer_games"?

<dataSource name="computer_games_form_data_source">

Found in:

templates/crud/view/adminhtml/uicomponent/${vendorname}${modulename}_${entityname}_form.xml
templates/crudEAV/view/adminhtml/uicomponent/${vendorname}${modulename}_${entityname}_form.xml

jalogut commented 7 years ago

Hi @rev42 ,

Thanks for noticing. I just fixed that together with your PR on version 1.6.4

Thanks for your contribution.