staempfli / magento2-module-image-resizer

Magento 2 Module to add simple image resizing capabilities in all blocks and .phtml templates
93 stars 32 forks source link

Feature request: Add more methods to the interface #12

Open tdgroot opened 6 years ago

tdgroot commented 6 years ago

Cool module! I implemented it into a project I'm working on, it works great. A few suggestions, though:

Please let me know what your thoughts are, I'm willing to contribute!

I had to create my own class to get it working:

<?php

namespace Marissen\QuotationSheet\Helper;

use Magento\Catalog\Model\Product;
use Staempfli\ImageResizer\Model\Resizer;

class ImageResizer extends Resizer
{
    public function getPath(Product $product): string
    {
        $imageObject = $product->getMediaGalleryImages()->getFirstItem();

        if (!$imageObject->getData('url')) {
            return '';
        }

        $this->resizeAndGetUrl($imageObject->getData('url'), 200, 200);

        return $this->getAbsolutePathResized() ?: '';
    }
}
jalogut commented 6 years ago

Hi @tdgroot

Thanks for your suggestions If you think that these methods can be handy for other people, we'd be glad to merge your PR.