search

staempfli / magento2-phpstorm-templates

PHPStorm Live template preferences for Magento 2 Projects
227 stars 48 forks source link

Changed Backend Model Image by variable #1

Closed osrecio closed 7 years ago

osrecio commented 7 years ago

Changed Staempfli\StoreLocator\Model\Locations by variable to stop and Change by desired Model

jalogut commented 7 years ago

Hi @osrecio thanks for your PR. What about adding 2 variables instead of on like that?

$vendor$\$package$\Model\Attribute\Backend\Image

What do you think?

osrecio commented 7 years ago

Sounds good!

I think is better than only set model.

Thanks for you efforts with awesome tool!

El 20 feb 2017, a las 12:57, Juan Alonso notifications@github.com escribió:

Hi @osrecio thanks for your PR. What about adding 2 variables instead of on like that?

$vendor$\$package\Model\Attribute\Backend\Image

What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jalogut commented 7 years ago

Hi @osrecio, could you also add "Model" after the variables:

$vendor$\$package$\Model\Attribute\Backend\Image

After that, I will accept the pull request and also upload a new .jar file with the changes.

Thanks

osrecio commented 7 years ago

Sorry, this happens to edit directly in github.com.

Solved!