search

staff-rs / staff

Music theory and score rendering library with midi, notes, chords, scales, and more.
https://staff-rs.github.io
MIT License
253 stars 11 forks source link

Upgrade to dioxus 0.5 #21

Open adlrwbr opened 3 months ago

adlrwbr commented 3 months ago

Hello,

Dioxus v0.5 deprecated the 'bump lifetime on components. The UI components (e.g. Staff, StaffElements) have lifetime parameters as they were built for Dioxus v0.4, but Cargo.toml depends on the latest git branch of Dioxus, which makes these components inaccessible. This results in #18 and cargo check --features=ui failing.

To fix this and re-expose the components as intended, I propose we

  1. Lock the dioxus dependencies at 0.4 across the dioxus-resize-observer, dioxus-use-mounted, and staff repositories.
  2. Create a tag for users to consume 0.4 components.
  3. Upgrade components to dioxus 0.5 and release new tag.

I'm happy to submit PRs for this. Lmk if you have feedback on this plan. Thanks.