Commandline Source Hierarchical Param Always Converted to Array

[numbnut]

Hi, I'm facing an issue using the Commandline source. If I define a hierarchical command line param like --db_host=myhost.org it is always parsed as an array. I think this is a bug.

Example:

file config_cmd_bug.py

from layeredconfig import LayeredConfig, Commandline

config = LayeredConfig(Commandline())

print("{}".format(config))

invocation

python config_cmd_bug.py --dbhost=string --db_host=array_of_strings

results in

'db': {'host': ['array_of_strings']}, 'dbhost': 'string'}

Thanks for the nice lib!

[staffanm]

Thanks for the report! Yes, this does indeed look like a bug, and I've been able to reproduce it with a unit test, so I hope to have it fixed soon.

[staffanm]

Quick update: The last argument in your sample invocation (--db_host=array_of_strings) uses a non-default separator between the section (db) and the parameter (host). The separator is normally -, so if using --db-host=array_of_string it works as expected.

However, the separator should be configurable, and when setting it to _ (using the sectionsep parameter to Commandline) the problem still persists. It's also probably a bug that a character not defined as a section separator sort of acts like it. But using eg --db-host=... might be a workaround for now.

[numbnut]

Thanks for the fast response! Next time I will try to submit a test case.

[numbnut]

By the way I totally agree with you.

[staffanm]

Fixed in the above commit. I'll try to push a 0.3.2 release to pypi this week. Again, thanks for the bug report!

[numbnut]

Very nice! Thank you so much!

[staffanm]

Version 0.3.2 with this fix applied is now up on pypi.

[numbnut]

Nice! Thank you!