Fix clickhouse ports and passwords in helpers

stafftastic / jitsu-chart

MIT License

14 stars 7 forks source link

Fix clickhouse ports and passwords in helpers #18

Closed mleklund closed 6 months ago

mleklund commented 7 months ago

Clickhouse needs port 8123 (HTTP) for console and rotor, but needs port 9000 (TCP) for bulker and ingest. See the docker-compose.yaml.
Clean up newlines that were creating username and passwords like "\njitsu".

I am not sure this is the cleanest way to handle the port issue. Another option would be to break out the clickhouse port and have differing defaults by service.

echozio commented 6 months ago

Good catch. Regarding the port issue, I think a decent solution without shifting things around too much is to provide separate parameters for the HTTP/TCP hosts on a global level while retaining the current behavior on a per-service basis.

I'll open a PR to your branch since I already made an implementation for it while looking into this. Let me know what you think.