search

stafftastic / jitsu-chart

13 stars 7 forks source link

tokenGenerator.image.tag can ask for images that do not exist #22

Open mleklund opened 5 months ago

mleklund commented 5 months ago 
          {{- $v := semver .Capabilities.KubeVersion.Version }}
          image: "{{ .Values.tokenGenerator.image.repository }}:{{ printf "%d.%d.%d" $v.Major $v.Minor $v.Patch }}"
          {{- end }}

It might just be bad luck on my part, but my eks version is v1.27.12-eks-adc7111, and there is no alpine/k8s image that matches. Unfortunately it does not look like they tag without the patch (1.27).

echozio commented 5 months ago

We attempted to resolve this earlier by using semver to parse it, but I suppose the patch version then ends up being 12-eks-adc7111? Will look into this

mleklund commented 5 months ago

No it gets 1.27.12 just fine, but alpine/k8s:1.27.12 does not exist. 1.27.13 and 1.27.11 do exist. There may not be a great fix for this. Probably related to https://github.com/alpine-docker/k8s/issues/75

echozio commented 5 months ago

Ah, sorry, skimmed it a little too quick. Probably not something we should work around in this chart, then. The image only uses kubectl to get/create a secret, so the best workaround will be just setting tokenGenerator.image.tag to something near that exists.

Thanks for bringing light to this. If this is going to be a common occurrence we may look at switching it out for something else, but well maintained utility images like this seem sort of few and far between.