search

stagecoachapp / Stagecoach

rails!
http://stagecoach.herokuapp.com/
2 stars 4 forks source link

Ryan code review #130

Closed mcafeeryan closed 12 years ago

mcafeeryan commented 12 years ago

_development_bug-fixes needs review and then to be merged so that Chris's high priority issues can be closed.

gpeal commented 12 years ago

was this reviewed by Jon?

gpeal commented 12 years ago

Why didn't you use named helpers to link to the project path in the header?

gpeal commented 12 years ago

Fix the indentation of the if statement in ApplicationController::unread_notification_count

gpeal commented 12 years ago

Why is there a new asset mobile view?

mcafeeryan commented 12 years ago

Yes On May 2, 2012 10:50 PM, "gpeal" < reply@reply.github.com> wrote:

was this reviewed by Jon?

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/130#issuecomment-5480473

gpeal commented 12 years ago

Can you merge it with development now? It should be done as soon as the code review is over

gpeal commented 12 years ago

I merged it