search

stagecoachapp / Stagecoach

rails!
http://stagecoach.herokuapp.com/
2 stars 4 forks source link

Notifications Breaking #138

Closed thekashifmalik closed 12 years ago

thekashifmalik commented 12 years ago

Notifications are breaking onprojectstagecoach.com

Follow these steps: -Log in. -Go to notifications. -Click a notification. -When the page loads, click the notifications button in the header. -Breaks.

thekashifmalik commented 12 years ago

Looks like a relative vs absolute URL issue.

gpeal commented 12 years ago

No problems for me? Can you be more specific?

thekashifmalik commented 12 years ago

So you did not follow the instructions I wrote out?

gpeal commented 12 years ago

I did and it worked fine for me

On Tue, May 8, 2012 at 8:08 PM, Kalail < reply@reply.github.com

wrote:

So you did not follow the instructions I wrote out?

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5590677

gpeal commented 12 years ago

You weren't very specific with your insructions though. What kind of notification did you get? What do you mean by "breaks"? 500 error? What do the logs say?

gpeal commented 12 years ago

@kalail I'm going to close this if you tell me how to reproduce it

thekashifmalik commented 12 years ago

I tried to but it apparently doesn't break for you. I think the issue is that the notifications button uses relative URL instead of absolute URL. See if thats the case?

Sent from my iPhone 4S

On May 11, 2012, at 1:00 PM, gpeal reply@reply.github.com wrote:

@kalail I'm going to close this if you tell me how to reproduce it

Reply to this email directly or view it on GitHub: https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657096

gpeal commented 12 years ago

Every type of notification links to something different... You need to be more specific. There might still be a problem

On Fri, May 11, 2012 at 1:02 PM, Kalail < reply@reply.github.com

wrote:

I tried to but it apparently doesn't break for you. I think the issue is that the notifications button uses relative URL instead of absolute URL. See if thats the case?

Sent from my iPhone 4S

On May 11, 2012, at 1:00 PM, gpeal reply@reply.github.com wrote:

@kalail I'm going to close this if you tell me how to reproduce it

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657096

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657133

thekashifmalik commented 12 years ago

I keep saying notification 'button' not notifications. The BUTTON on the header that is called the NOTIFICATIONS BUTTON seems to be a relative link, when it should be an absolute link.

Sent from my iPhone 4S

On May 11, 2012, at 1:10 PM, gpeal reply@reply.github.com wrote:

Every type of notification links to something different... You need to be more specific. There might still be a problem

On Fri, May 11, 2012 at 1:02 PM, Kalail < reply@reply.github.com

wrote:

I tried to but it apparently doesn't break for you. I think the issue is that the notifications button uses relative URL instead of absolute URL. See if thats the case?

Sent from my iPhone 4S

On May 11, 2012, at 1:00 PM, gpeal reply@reply.github.com wrote:

@kalail I'm going to close this if you tell me how to reproduce it

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657096

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657133

Reply to this email directly or view it on GitHub: https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657298

thekashifmalik commented 12 years ago

I've literally just given you the proposed fix. Can you confirm that this is infact the case?

Sent from my iPhone 4S

On May 11, 2012, at 1:10 PM, gpeal reply@reply.github.com wrote:

Every type of notification links to something different... You need to be more specific. There might still be a problem

On Fri, May 11, 2012 at 1:02 PM, Kalail < reply@reply.github.com

wrote:

I tried to but it apparently doesn't break for you. I think the issue is that the notifications button uses relative URL instead of absolute URL. See if thats the case?

Sent from my iPhone 4S

On May 11, 2012, at 1:00 PM, gpeal reply@reply.github.com wrote:

@kalail I'm going to close this if you tell me how to reproduce it

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657096

Reply to this email directly or view it on GitHub:

https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657133

Reply to this email directly or view it on GitHub: https://github.com/New-Media/nu-new-media-film-project/issues/138#issuecomment-5657298

gpeal commented 12 years ago

The next person who works, make a commit right on development that adds a / before the notifications_path in the application_helper. This is really important. PLease hop on this

gpeal commented 12 years ago

The next person who works, make a commit right on development that adds a / before the notifications_path in the application_helper. This is really important. PLease hop on this

gpeal commented 12 years ago

fixed in bea798722a77b2f133dc270526fb8a500e3bc23d