Unicast and Sync packet support

stagehacks / stagehack-sACN

Library for sending and receiving sACN (E1.31) lighting data

Do What The F*ck You Want To Public License

14 stars 4 forks source link

Unicast and Sync packet support #3

Closed twotabsofacid closed 3 years ago

twotabsofacid commented 3 years ago

Hey again – this PR is probably the better one to take a look at. Sync is now its own file, basically a clone of Sender but seems cleaner this way. I'm getting some weirdness when trying to add a test for the Sync packet with the Receiver, need to look into that a bit more. But, I can confirm that this does work to send data via Unicast to systems that require a sync packet in order to update.

sparks-alec commented 3 years ago

Can you submit two separate PR's for unicast and sync? Unicast is excellent and I'm ready to merge, but I think there's more work to be done on sync.

sparks-alec commented 3 years ago

I'm also changing the whole project to space indentation because A) it's the right thing to do in general :D B) it should make integrating your code easier

twotabsofacid commented 3 years ago

Thanks @sparks-alec ! gonna close this one then and just add unicast support on a new PR