stagemonitor / stagemonitor-mailinglist

GitHub issues abused as a mailing list
3 stars 0 forks source link

ES creds in an exception log #63

Open gopi-nath opened 6 years ago

gopi-nath commented 6 years ago

Hi @felixbarny & @trampi,

The ES creds are appearing in logs again. Could you please take a look at it?

28 Dec 2017 00:41:27,886 ERROR [async-elasticsearch] ElasticsearchClient:194 - [] - [] - Error while updating kibana index pattern, definition = java.io.IOException: Server returned HTTP respo nse code: 401 for URL: https://user:password@elasticsearch.myweb.net/.kibana/index-pattern/stagemonitor-metrics-*, pattern path = kibana/stagemonitor-metrics-kibana-index-patter n.json

28 Dec 2017 00:41:28,111 WARN [async-elasticsearch] ElasticsearchClient$BulkErrorReportingResponseHandler:449 - [] - [] - Error(s) while sending a _bulk request to elasticsearch: failed to parse [timeFrom]

28 Dec 2017 00:41:28,236 ERROR [async-elasticsearch] ElasticsearchClient:194 - [] - [] - Error while updating kibana index pattern, definition = java.io.IOException: Server returned HTTP respo nse code: 401 for URL: https://user:password@elasticsearch.mweb.net/.kibana/index-pattern/stagemonitor-spans-*, pattern path = kibana/stagemonitor-spans-kibana-index-pattern.js on

gopi-nath commented 6 years ago

Hey @felixbarny Any updates in here?

trampi commented 6 years ago

Hi @gopi-nath, sorry for not responding earlier. @felixbarny is currently on vacation, he will be here again on the beginning of the next week. I did take a quick look and think it should be easily solvable. As far as I know Felix, he will probably release a fix in a timely manner when he is back. Unfortunately do I not have the rights to release a fixed version.

gopi-nath commented 6 years ago

@trampi Thanks a lot!

felixbarny commented 6 years ago

I've released 0.86.1 which should be available via maven central in the next few minutes: https://github.com/stagemonitor/stagemonitor/releases/tag/0.86.1

gopi-nath commented 6 years ago

Thanks! @felixbarny

felixbarny commented 6 years ago

I have fixed another set of cases which could lead to credentials being logged: https://github.com/stagemonitor/stagemonitor/releases/tag/0.86.2