search

stainedhat / pyedhrec

A Python wrapper for the amazing EDHRec.com site
Apache License 2.0
0 stars 0 forks source link

Failure to Normalized some Card Names #1

Open MrTyton opened 2 months ago

MrTyton commented 2 months ago

Two issues that I've discovered with get_card_details

1) If you pass in the back side of a card, such as Mystic Peak, it fails the lookup since it doesn't re-normalize it to the front side.

2) If you pass in a split card (which EDHREC lists in the decklists with double slashes, Road // Ruin, then it doesn't normalize it to something that can be looked up, such as Road-Ruin, which does work.

Both of the above errors will throw 403.

MrTyton commented 2 months ago

It also fails with some of the lotr cards

Fear, Fire, Foes! fails, and it should be normalized to just fear-fire-foes, and Lórien Revealed should be normalized to just lorien-revealed

Slusks commented 1 month ago

@MrTyton do you know what the rate limit on the EDHRec API is? And did you find any other oddballs outside of double faced cards?