stainlessai / micronaut-jupyter

A Micronaut configuration that integrates your app with an existing Jupyter installation.
https://stainlessai.github.io/micronaut-jupyter
Apache License 2.0
9 stars 5 forks source link

MJ-10 ⁃ Default `jupyter.server-url` config to embedded server url #12

Closed stainlessbot closed 4 years ago

stainlessbot commented 4 years ago

The current architecture of the configuration does allow the micronaut app to be running in a different environment than Jupyter so long as they both have access to a single filesystem. For this reason, I think we should leave the jupyter.server-url config in place. However, it doesn't need to be mandatory, have it default to the url of the embedded server (if there is one). If there is no embedded server (and no value was given), then throw an error.

┆Issue Type: Task ┆Priority: High ┆Status: Resolved ┆Fix Versions: v0.1.0 ┆Issue Number: MJ-10 ┆Epic: Kernel