search

stakater / Forecastle

Forecastle is a control panel which dynamically discovers and provides a launchpad to access applications deployed on Kubernetes – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
601 stars 62 forks source link

Fix for Dockerfile smell DL4000 #342

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "build/package/Dockerfile.build" contains the best practice violation DL4000 detected by the hadolint tool.

The smell DL4000 occurs when the deprecated MAINTAINER instruction is used. This pull request proposes a fix for that smell generated by my fixing tool. The patch was manually verified before opening the pull request. To fix this smell, specifically, the MAINTAINER instruction is replaced by an equivalent LABEL instruction as recommended by the official guidelines.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

github-actions[bot] commented 1 year ago

@grosa1 Image is available for testing. docker pull stakater/forecastle:SNAPSHOT-PR-342-778b65e9