search

stakater / Forecastle

Forecastle is a control panel which dynamically discovers and provides a launchpad to access applications deployed on Kubernetes – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
609 stars 62 forks source link

[BUG] the chart creates a duplicate security context under certain conditions #428

Open wy100101 opened 5 months ago

wy100101 commented 5 months ago

Describe the bug the forecastle chart creates a duplicate security context when you set .Values.forecastle.deployment.securityContext resulting in an invalid manifest.

To Reproduce helm deploy forecastle with securityContext set under .Values.forecastle.deployment.securityContext will result in the following error: Helm install failed for release forecastle/forecastle with chart forecastle@v1.0.142: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors: line 46: mapping key "securityContext" already defined at line 35

Expected behavior A clean helm install

Screenshots If applicable, add screenshots to help explain your problem.

Environment

Additional context Add any other context about the problem here.

bnallapeta commented 4 months ago

@wy100101 Ack. Will work on it.

karl-johan-grahn commented 3 months ago

The issue can be reproduced with helm template.

Unit test could be added with d3adb5/helm-unittest-action. Example tests: https://github.com/d3adb5/helm-unittest-action/blob/master/example-chart/tests/example_test.yaml