search

stakater / GitWebhookProxy

A proxy to let webhooks reach running services behind a firewall – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
188 stars 52 forks source link

Can't handle if Github PR is labelled #72

Closed nareshnayini closed 5 years ago

nareshnayini commented 5 years ago

2019/10/01 20:52:19 Received event type: pull_request 2019/10/01 20:52:19 Github payload unmarshaling failed for Pull Request event: json: cannot unmarshal object into Go struct field .labels of type string 2019/10/01 20:52:19 Incoming request from user: 2019/10/01 20:52:19 Ignoring request for user:

kahootali commented 5 years ago

@nareshnayini Can you create a PR with your updated payload?

nareshnayini commented 5 years ago

@kahootali do you mean PR in this repo https://github.com/stakater/GitWebhookProxy ?

kahootali commented 5 years ago

Yes

nareshnayini commented 5 years ago

hey, If you mean by creating a PR with a fix for this - sorry, I don't have go programming knowledge. But I can share the payload if that helps. Let me know.

kahootali commented 5 years ago

@nareshnayini Can you please deploy with the image version, stakater/gitwebhookproxy:SNAPSHOT-PR-73-1 and let us know if it works for you?

nareshnayini commented 5 years ago

@kahootali Verified with this image version with PR having both Label as well as Team reviewer. It's working fine in both cases now. Thank you.

waseem-h commented 5 years ago

Closing this. Fixed by #73