search

stakater / GitWebhookProxy

A proxy to let webhooks reach running services behind a firewall – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
188 stars 52 forks source link

remove namespace from ingress template #95

Closed TheMeier closed 3 years ago

TheMeier commented 3 years ago

or use {{ Release.Namespace }}, but in that case it should be added to all templates to be consistent

akanshgupta commented 3 years ago

@TheMeier and @ahmedwaleedmalik can you please provide the significance of removing namespace from the ingress template?

TheMeier commented 3 years ago

Helm has a namesapce parameter that should be used and can be referenced with {{ Release.Namespace }}. If you omit it in the template it is implicitly set to that value. In any case it was inconsistent between the templates. All templates did not set it except for this one.