search

stakater / IngressMonitorController

A Kubernetes controller to watch ingresses and create liveness alerts for your apps/microservices in UptimeRobot, StatusCake, Pingdom, etc. – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
600 stars 104 forks source link

Add support for integrations in Pingdom #158

Closed sharkymcdongles closed 5 years ago

sharkymcdongles commented 5 years ago

The check api definitions are here:

https://www.pingdom.com/api/2.1/#MethodCreate+New+Check

Basically, we need to be able to specify the integration ids for checks to allow checks created by the controller to have integration features.

integrationids | Integration identifiers. For example integrationids=11,22,33 | Comma separated Integers

The work is minimal, so I will see if I can submit a PR unless someone more familiar wants to do it.

rasheedamir commented 5 years ago

@sharkymcdongles that will be awesome if you can submit a PR!

kahootali commented 5 years ago

@sharkymcdongles @rasheedamir, FYI @boxcee is working on it and has created a PR, some tests are failing, we are working on them, it will be fixed by today most probably

aliartiza75 commented 5 years ago

the fix has been pushed,

Test fail reasons

In config tests test oracle was not being constructed correctly.