stakater / IngressMonitorController

A Kubernetes controller to watch ingresses and create liveness alerts for your apps/microservices in UptimeRobot, StatusCake, Pingdom, etc. – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
560 stars 102 forks source link

Uptimerobot Statuspage updates broken #499

Open mwipplinger-ftapi opened 1 year ago

mwipplinger-ftapi commented 1 year ago

We've realized while trying to automatically set our uptimerobot monitors to all be added to a uptimerobot statuspage that the feature is currently broken.

The error messages we see when running the operator with our config are the following:

{"level":"info","ts":1687426035.3645682,"logger":"uptime-monitor-test","msg":"There are some new changes in <monitor_name> monitor"}
{"level":"info","ts":1687426035.414855,"logger":"uptime-monitor-test","msg":"Monitor Updated: <monitor_name>"}
{"level":"info","ts":1687426035.477496,"logger":"uptime-monitor-test","msg":"Status Page couldn't be updated: "}
{"level":"info","ts":1687426035.4775262,"logger":"uptime-monitor-test","msg":"Monitor couldn't be added to status page: Status Page couldn't be updated: "}

After a bit of analysis from our side we have identified that the required parameters for the editPSP api must have changed at some point and the current implementation of this controller does not reflect that (The API expects the friendly_name of a psp in addition to it's id which it probably didn't do beforehand)

Also it seems like the statuspage tests were "temporally disabled" at some point by being commented out and that was never reverted so that's why this breaking change was not caught.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 60 days with no activity.