stakater / IngressMonitorController

A Kubernetes controller to watch ingresses and create liveness alerts for your apps/microservices in UptimeRobot, StatusCake, Pingdom, etc. – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
599 stars 104 forks source link

Support for arm64 image #505

Closed gothka closed 10 months ago

gothka commented 1 year ago

Hi, i'm checking to see if there's any plan to start supporting arm64 builds for the controller image as i couldn't any tag that supports that on docker hub. I'm happy to submit a PR :)

MuneebAijaz commented 1 year ago

hi @gothka , would you like to submit a PR for the suggested change? We do have binaries pushed for some architectures, but images are based on one arch

tuxpeople commented 1 year ago

I'm interested as well, but can't do a pr as I don't know anything about goreleaser, which you are using for the releases. I've only experience building multi-arch images using the docker or buildah actions.

@gothka I'm happy to test arm64 once you have such an image

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 60 days with no activity.

nohant commented 1 year ago

yeah, we need that too, i think it should also need some edit on the github action because here:

      uses: docker/build-push-action@v4
      with:
        context: .
        file: ${{ env.DOCKER_FILE_PATH  }}
        pull: true
        push: true
        cache-to: type=inline
        tags: |
          ${{ env.IMAGE_REPOSITORY }}:${{ steps.generate_tag.outputs.new_tag }}
        labels: |
          org.opencontainers.image.source=${{ github.event.repository.clone_url }}
          org.opencontainers.image.created=${{ steps.prep.outputs.created }}
          org.opencontainers.image.revision=${{ github.sha }}

its only setting the default version. But by the look of it, the build version is configurer inside the dockerfile here: RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -mod=mod -a -o manager main.go

nohant commented 1 year ago

@tuxpeople I'm sorry, you have to build locally from the branch, the default pipeline don't build for arm. Thanks for your eventual time.

nohant commented 1 year ago

May i help in any other way? its been a week and we would like to use this component in our arm cluster.

bnallapeta commented 1 year ago

@nohant I will take a look at this and get back to you soon.

bnallapeta commented 1 year ago

@nohant I just replied on #526. Please check.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 60 days with no activity.

MuneebAijaz commented 10 months ago

https://github.com/stakater/IngressMonitorController/pull/526 i suppose issue was fixed in the mentioned PR, please reopen the issue if any concerns.