search

stakater / IngressMonitorController

A Kubernetes controller to watch ingresses and create liveness alerts for your apps/microservices in UptimeRobot, StatusCake, Pingdom, etc. – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
599 stars 104 forks source link

feat(#505): enable default multi-arch build #526

Closed nohant closed 1 year ago

nohant commented 1 year ago

this is done as a basic configuration for https://github.com/stakater/IngressMonitorController/issues/505 the build is correctly working on my host but i dont know how to test it more :(

the part of the github action i think should be discussed or at least taken care of by someone more expert than me

github-actions[bot] commented 1 year ago

@nohant Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-526-a3c36478

bnallapeta commented 1 year ago

@nohant Instead of having different tags for different platforms for the images, it is easier on the user to just have the same tag and let docker figure out the platform. If you take a look at our Reloader images, we have done this already by having the same tag with multi-platform support. Could you please follow the same standard here too? The changes here look mostly right except the Docker push step. You can refer to this one for reference.

nohant commented 1 year ago

@bnallapeta you are right im sorry, im too used to how we do that. Now it should work the same as you said in the other configurations.

bnallapeta commented 1 year ago

@nohant Its still not generating multi arch images. I am checking on this. Will get back to you.

nohant commented 1 year ago

@bnallapeta don't worry mate, I'm sure i've forgot something :D thanks for the help, really appreciate.

nohant commented 1 year ago

fixed all the request points, sorry for the matrix leftover.

bnallapeta commented 1 year ago

@nohant We now have multi arch support for IMC. Thank you :)

https://hub.docker.com/layers/stakater/ingressmonitorcontroller/v2.1.39/images/sha256-f9347ced1826bc88f83ca4091499c706d25188e6b17db80bd697f4fc5d7ff706?context=explore