search

stakater / IngressMonitorController

A Kubernetes controller to watch ingresses and create liveness alerts for your apps/microservices in UptimeRobot, StatusCake, Pingdom, etc. – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
599 stars 104 forks source link

StatusCake nodeLocations are not configured #540

Closed tibuntu closed 11 months ago

tibuntu commented 1 year ago

Describe the bug In the past I was able to configure test locations for StatusCake using nodeLocations in the spec of the endpointmonitor. However, we deployed a couple of new endpointmonitors and the locations are not set anymore.

To Reproduce Deploy a EndpointMonitor with a statusCakeConfig:

apiVersion: endpointmonitor.stakater.com/v1alpha1
kind: EndpointMonitor
metadata:
  name: statuscake-test
  namespace: default
spec:
  forceHttps: true
  statusCakeConfig:
    basicAuthUser: myUser
    checkRate: 300
    confirmation: 1
    enableSslAlert: true
    followRedirect: true
    nodeLocations: frankfurt,amsterdam,stockholm
    paused: false
    port: 443
    realBrowser: true
    statusCodes: 401,404,500,502,503
    testTags: cloud
    testType: HTTP
    triggerRate: 1
  url: https://some-url.my-domain.com/

Expected behavior The check is created in statuscake and the locations are selected as in the spec.

Environment

MuneebAijaz commented 1 year ago

hi @tibuntu , i will check this, but statuscake api was changed around a year back if i remember correctly, changing the api might have broken the locations field. We do welcome PRs if you are able to identify and can fix the issue.

tibuntu commented 1 year ago

@MuneebAijaz thanks for pointing that out! I was able to fix it, see related PR.