search

stakater / IngressMonitorController

A Kubernetes controller to watch ingresses and create liveness alerts for your apps/microservices in UptimeRobot, StatusCake, Pingdom, etc. – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
599 stars 104 forks source link

StatusCake: Use regions instead of node_locations #542

Closed tibuntu closed 11 months ago

tibuntu commented 1 year ago

Hi, as described in #540 setting nodeLocations didn't have any affect.

Thanks to the response of @MuneebAijaz I was able to track down the required changes.

I was able to build the IngressMonitorController locally, and after deploying my tag to Kubernetes, the regions were set correctly again.

github-actions[bot] commented 1 year ago

@tibuntu Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-542-25dfc151

MuneebAijaz commented 11 months ago

@tibuntu pls resolve the conflicts for it to be able to merged

tibuntu commented 11 months ago

Hi @MuneebAijaz, done.

tibuntu commented 11 months ago

@MuneebAijaz any chance this is going to me merged soon?

MuneebAijaz commented 11 months ago

@tibuntu apologies, busy days at work

tibuntu commented 11 months ago

@MuneebAijaz that was quicker than expected. Sorry for any pressure, I really love this piece of software but the broken functionally stopped us from using it! Thank you very much!

MuneebAijaz commented 11 months ago

@tibuntu no worries, i understand the frustration if any. feel free to tag anytime if its urgent. Difficult to keep track of many things during the day