stakater / IngressMonitorController

A Kubernetes controller to watch ingresses and create liveness alerts for your apps/microservices in UptimeRobot, StatusCake, Pingdom, etc. – [✩Star] if you're using it!
https://stakater.com
Apache License 2.0
608 stars 106 forks source link

Common check interval annotation #69

Open hazim1093 opened 6 years ago

hazim1093 commented 6 years ago

As suggested by The annotation monitor.stakater.com/pingdom/resolution can be abstracted into a general annotation such as monitor.stakater.com/resolutionTime as it can be used with premium services of uptimerobot and probably other services providers too.

Make it the annotation common and document that it is currently supported with pingdom only, we can later add support for resolution time for uptimerobot as well (Currently uptimerobot does not allow specifying resolution times manually for free services)

drubin commented 6 years ago

But it does support it easily with the premium version.

https://uptimerobot.com/api#newMonitorWrap

While we are abstracting away these thigns it might also be nice to abstract away the AlertContacts as well. Different services might need to go to different contacts

It also explains the confusing _0_0 in the alert contacts configuration.

alert_contacts - optional (the alert contacts to be notified when the monitor goes up/down.Multiple alert_contact>ids can be sent like alert_contacts=457_0_0-373_5_0-8956_2_3 where alertcontact>ids are seperated with - and threshold + recurrence are seperated with . For ex: alert_contacts=457_5_0 refers to 457 being the alert_contact>id, 5 being the threshold and 0 being the recurrence. As the threshold and recurrence is only available in the Pro Plan, they are always 0 in the Free Plan)

rasheedamir commented 6 years ago

Agreed @drubin; can you please create a separate issue and suggest/mention the abstracting of AlertContacts in it?

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 60 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 30 days since being marked as stale.

karl-johan-grahn commented 1 year ago

Reopening issues that inadvertently were closed as stale