search

stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!
https://docs.stakater.com/reloader/
Apache License 2.0
7.73k stars 514 forks source link

Reloader Reporting and Alerting #320

Open AnuragEkkati opened 2 years ago

AnuragEkkati commented 2 years ago

Reloader as of today from what I understand doesn't report which deployment/statefulset/daemonset has been reloaded by it and what event ( secret/configmap ) triggered it.

Also it will be really awesome if we have a simple webhook which we can enable to alert when the reloader did its job of reloading and provide info related to that

/kind feature

AnuragEkkati commented 2 years ago

Can i work on this feature ?

rasheedamir commented 2 years ago

@faizanahmad055 what do you think? Would be nice to add this feature I believe

faizanahmad055 commented 2 years ago

@AnuragEkkati Thank you, it is a good feature and you are welcome to work on it. But I think we should make alerting optional because depending on the number of reloads happening, it can easily cluster the alerting channels. Currently, it does show you information about what deployment and secret/configmap got updated in the logs. But it doesn't show the content that was updated because of security reasons so we need to be careful about that part as well.

AnuragEkkati commented 2 years ago

Yes, it should be optional

vinzent commented 2 years ago

Reporting it as a standard k8s event would be nice.

Mockup:

$ kubecetl get events
LAST SEEN   TYPE     REASON           OBJECT              MESSAGE
2m          Normal   ReloadTriggered  deployment/myapp    Reload of deployment "myapp" triggered due to changed ConfigMap "ca-bundle"

We use https://github.com/openshift/eventrouter/ to log events to stdout where they get picked up by the central logging.