search

stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!
https://docs.stakater.com/reloader/
Apache License 2.0
7.45k stars 493 forks source link

Reloader image with docker v2.2 #534

Open ajaykanse opened 1 year ago

ajaykanse commented 1 year ago

Could you please make reloader image available in docker v2.2 format as well along with oci format ? Some of the tools such as Artifactory gives issue downloading oci v1 images. Is this possible ?

karl-johan-grahn commented 12 months ago

What issue does Artifactory give?

ajaykanse commented 12 months ago

Artifactory (proxy/remote repo ) unable to fetch the image and gives below error - Error in getting information for 'library/docker/latest/list.manifest.json'. cant fetch token for repo. As a workaroud we have to download image manually and then publish to artifactory which converted it to docker v2.2 format. The original image manifest is - "ManifestType": "application/vnd.oci.image.manifest.v1+json" After workaround and publishing image to Artifactory - "ManifestType": "application/vnd.docker.distribution.manifest.v2+json" Note - We also have to update Artifactory to support OCI images

damian-krawczyk commented 8 months ago

Hi, by having it in docker format, you could make it supported by Microsoft Defender for Containers. Could you consider it?

https://github.com/MicrosoftDocs/azure-docs/blob/bc6925fcb9c94d51005292ab8cd369022c9c2645/articles/defender-for-cloud/support-matrix-defender-for-containers.md?plain=1#L71

ajaykanse commented 8 months ago

If we can have image with both oci and docker supported with the correct format would be great.