stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!
https://docs.stakater.com/reloader/
Apache License 2.0
7.65k stars 510 forks source link

Pipeline sometimes fails at the "Commit Files" step which prevents Release from being created unless manual intervention is done #636

Open IdanAdar opened 7 months ago

IdanAdar commented 7 months ago

I was downloading the latest image available, hoping it will resolve open UBI base OS vulnerabilities -- which it didn't, but also this tag, 1.0.79, is missing from the GitHub Releases page.

karl-johan-grahn commented 7 months ago

Hmm, how do you mean, the tag is https://github.com/stakater/Reloader/tree/v1.0.79 and the release is https://github.com/stakater/Reloader/releases/tag/v1.0.79

IdanAdar commented 7 months ago

It was there before.... the image was available first for a good amount of hours.

karl-johan-grahn commented 7 months ago

You mean the image is not there?

karl-johan-grahn commented 7 months ago

It has been downloaded 1844 times at the time of writing: https://github.com/orgs/stakater/packages/container/reloader/203494991?tag=v1.0.79

fdberlking commented 7 months ago

It has been downloaded 1844 times at the time of writing: https://github.com/orgs/stakater/packages/container/reloader/203494991?tag=v1.0.79

@karl-johan-grahn what @IdanAdar means is that the release itself is just available since 17 hours whilst it has been already possible to download v1.0.79 related images and Helm charts since Thursday/Friday (at least that's the time I pulled it).

Perhaps, the release itself has been created to a later point in time than the actual image/helm chart was already ready.

grafik

MuneebAijaz commented 7 months ago

hi @IdanAdar , we have an issue in the pipelines that has been there for a while. I myself couldn't determine the source of it, although there are "forced" fixes for it, i preferred to not do it and find the source of the problem. it fails sometimes at Commit Files step https://github.com/stakater/Reloader/actions/runs/8635492298/job/23673318641. And it gets resolved when rerunning the pipeline. The step above Commit Files was for investigating the same issue, about .git objects.

I will keep the issue opened, in case someone wants to pick it up later, but the heading needs to be changed since the version is now released.