feat(log-level): add option to set logLevel in chart

stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!

https://docs.stakater.com/reloader/

Apache License 2.0

7.12k stars 476 forks source link

feat(log-level): add option to set logLevel in chart #687

Open dabcoder opened 3 weeks ago

dabcoder commented 3 weeks ago

Implements #681.

github-actions[bot] commented 3 weeks ago

@dabcoder Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-687-9b21bf36\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-687-UBI-9b21bf36

dabcoder commented 3 weeks ago

Tested with:

spec:
  containers:
    - args:
        - --log-level=error

Yet in the actual container logs I can see:

time="2024-06-13T12:21:17Z" level=info msg="Environment: Kubernetes"

Feedback welcome.

dabcoder commented 2 weeks ago

cc @MuneebAijaz

MuneebAijaz commented 2 weeks ago

hi @dabcoder thanks for the PR, if the actual flag doesn't work for log levels, we might need to fix that first.

dabcoder commented 2 weeks ago

Yes that's what I was trying to check and figure out but I don't immediately see any issues with the flag in the codebase. I can take another look anyway.