search

stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!
https://docs.stakater.com/reloader/
Apache License 2.0
7.12k stars 476 forks source link

feature reload-on-delete implemented, test cases enhanced #695

Open deschmih opened 2 weeks ago

deschmih commented 2 weeks ago

This PR contains the feature "reload-on-delete" as enhancement refering to issue #622. For beeing backwards compatible an additional flag reload-on-delete at commandline is implemented for using this feature. This corresponding flag reloadOnDelete is also now part in the values.yaml of the helm chart. Testcases are enhaced.

github-actions[bot] commented 2 weeks ago

@deschmih Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-2260d728\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-695-UBI-2260d728

deschmih commented 2 weeks ago

@MuneebAijaz reviewers are welcome ;-) Test cases are enhanced.

deschmih commented 2 days ago

@MuneebAijaz - Are you the right person to review this pull request in a timely manner ?

MuneebAijaz commented 2 days ago

@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.

bartselect commented 2 days ago

@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow.

I believe in you brotha

MuneebAijaz commented 1 day ago

hi @deschmih PR looks fine. can you resolve conflicts and pls separate out docs changes in another PR? There's is an ongoing issue about docs and code workflows running together causing issues.