stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!
https://docs.stakater.com/reloader/
Apache License 2.0
7.12k stars 476 forks source link

[BUG] Latest chart has has invalid version numbers #698

Closed pinkfloydx33 closed 1 week ago

pinkfloydx33 commented 2 weeks ago

Describe the bug The current chart indicates version numbers with a double v, i.e. vv1.0.110. This is present in the default labels as well as the image tag.

https://github.com/stakater/Reloader/blob/b73b04d9aeca86d7230e0f9ab146baeb576ed54f/deployments/kubernetes/chart/reloader/values.yaml#L92-L96

This tag does not exist in the registry and thus the chart fails to install. In our case, an automatic upgrade via Flux has begun failing across all of our clusters where we allow minor version upgrades.

igorhrcek commented 2 weeks ago

True, I can confirm the same issue:

│   Warning  Failed     46m (x4 over 48m)      kubelet            Failed to pull image "ghcr.io/stakater/reloader:vv1.0.110": rpc error: code = NotFound desc = failed to pull and unpack image "ghcr.io/stakater/reloader:vv1.0.110": fail │
│ ed to resolve reference "ghcr.io/stakater/reloader:vv1.0.110": ghcr.io/stakater/reloader:vv1.0.110: not found                                                                                                                             │
MickaelCa commented 2 weeks ago

Same here

Robusta Alert ● Container reloader ● Image ghcr.io/stakater/reloader:vv1.0.110 ● Reason Image not found ● Fix Make sure the image repository, image name and image tag are correct.

mimartin12 commented 2 weeks ago

Having similar issues, but with the latest version, (1.0.113). It's attempting to pull vv1.0.112, which I wouldn't expect in version 1.0.113. Either way, the image is miss-tagged.

image
rasheedamir commented 2 weeks ago

https://github.com/stakater/Reloader/pull/686

MuneebAijaz commented 2 weeks ago

hi @pinkfloydx33 apologies for the trouble, can you check with 1.0.114 if it fixes the issue? Apparently, docs and code workflows get triggered at the same time for PRs that have both kinds of changes, resulting in a clash. we will take a look at it in the upcoming week

pinkfloydx33 commented 2 weeks ago

Hi @MuneebAijaz. It appears to have resolved itself. Thank you

MuneebAijaz commented 1 week ago

closing it considering new versions fixed the issue