Tell Go runtime about the CPU & memory limits.

stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!

https://docs.stakater.com/reloader/

Apache License 2.0

7.47k stars 498 forks source link

Tell Go runtime about the CPU & memory limits. #699

Closed mindw closed 1 month ago

mindw commented 3 months ago

Background: https://blog.howardjohn.info/posts/gomaxprocs/ https://github.com/uber-go/automaxprocs https://tip.golang.org/doc/gc-guide#Memory_limit

github-actions[bot] commented 3 months ago

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-7e7e3d80\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-7e7e3d80

bnallapeta commented 3 months ago

@mindw Thanks for the PR. Could you update the PR description clearly to reflect the purpose of your changes?

Also, you cannot update this file directly as it is a generated file from our pipelines.

github-actions[bot] commented 3 months ago

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-72c623b0\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-72c623b0

mindw commented 3 months ago

@mindw Thanks for the PR. Could you update the PR description clearly to reflect the purpose of your changes?

Also, you cannot update this file directly as it is a generated file from our pipelines.

@bnallapeta , Thank you for looking into this and the pointing this out.

Updated the helm chart and provided links in the description.

github-actions[bot] commented 3 months ago

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-a01a6749\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-a01a6749

github-actions[bot] commented 3 months ago

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-658cb7c1\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-658cb7c1

bnallapeta commented 3 months ago

@mindw I think we are good to merge this pending one last comment.

bnallapeta commented 2 months ago

@mindw gentle reminder.

github-actions[bot] commented 2 months ago

@mindw Images are available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-36484c30\ndocker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-699-UBI-36484c30

stefanandres commented 1 month ago

This change broke HA and the default setting, see https://github.com/stakater/Reloader/pull/723

mindw commented 1 month ago

@stefanandres sorry about that :( most likely a merge artifact.