search

stakater / Reloader

A Kubernetes controller to watch changes in ConfigMap and Secrets and do rolling upgrades on Pods with their associated Deployment, StatefulSet, DaemonSet and DeploymentConfig – [✩Star] if you're using it!
https://docs.stakater.com/reloader/
Apache License 2.0
7.72k stars 513 forks source link

Fix the global image tages #783

Closed bjorns163 closed 3 days ago

bjorns163 commented 2 weeks ago

When testings the helm chart on OpenShift 4.14 (Kubernetes version: v1.27.16) I noticed that these tags global.imageRegistry and global.imagePullSecrets were not correctly working, here the fix

MuneebAijaz commented 5 days ago

hi @bjorns163 can u pls rebase on master branch, and update helm chart version prematurely in chart.yaml?

MuneebAijaz commented 5 days ago

You'd need to update the version here to 1.2.1 we update it before releasing now so git state is synced with chart in artifact repo https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/Chart.yaml#L6

MuneebAijaz commented 5 days ago

You'd need to update the version here to 1.2.1 we update it before releasing now so git state is synced with chart in artifact repo https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/Chart.yaml#L6

bjorns163 commented 4 days ago

Ok I've updated the version and synced project

MuneebAijaz commented 4 days ago

appVersion will stay the same because theres no image available for 1.2.1 yet. we plan to separate out versioning for these two things. so in ur case, chart version will be ahead of image version, which is completely fine. appVersion points to application version, which will stay the same

bjorns163 commented 4 days ago

Ok i set the appversion back.