search

stakater / application

Generic helm chart for all kind of applications
http://stakater.com
MIT License
213 stars 88 forks source link

quote app.kubernetes.io/version label #238

Closed pauvos closed 1 year ago

pauvos commented 1 year ago

Thanks for updating the chart! I can now use latest@sha256:asdasd image tags for all kinds of small opensource projects.

I noticed a regression while trying to deploy postgres with tag: 15.2, '15.2' or "15.2":

$ helm template postgresql stakater/application --version=2.1.3 --set deployment.image.tag=15.2 --validate
Error: unable to build kubernetes objects from release manifest: unable to decode "": json: cannot unmarshal number into Go struct field ObjectMeta.metadata.labels of type string

The quotation marks always seem to get lost in the parser. The chart renders fine but the kubernetes API refuses "float64" as label value.

The fix produces app.kubernetes.io/version: "15.2" in all of the above cases.

github-actions[bot] commented 1 year ago

@mustafaStakater validation successful`