search

stakater / application

Generic helm chart for all kind of applications
http://stakater.com
MIT License
192 stars 83 forks source link

Automatic releases and changelog updates #241

Open aslafy-z opened 1 year ago

aslafy-z commented 1 year ago

I'd like to see automatic release and changelog updates in such a simple repository. You can see an example implementation using semantic-release in this repository https://github.com/aslafy-z/helm-git. semantic-release also knowns how to maintain a CHANGELOG.md like you do in this repository. There is also pre-packaged GitHub Actions to run, such as: https://github.com/marketplace/actions/action-for-semantic-release. What do you think?

rasheedamir commented 1 year ago

@aslafy-z PR is welcome! Lets do it

aslafy-z commented 1 year ago

@mustafaStakater please have a look to semantic-release, it handles the full chain, no need to do any custom sauce :)

mustafaStakater commented 1 year ago

@aslafy-z okay ill take a look into it

aslafy-z commented 1 year ago

Also, semantic release uses conventional commits convention to define how to bump the semver. In order for the full chain to be working correctly, we should enforce commit names. Either by enforcing on pr titles and enabling squash and merge strategy, or enforcing on all commits inside PRS and continue with classing merge strategy.

aslafy-z commented 1 year ago

@mustafaStakater any updates?

mustafaStakater commented 1 year ago

hello @aslafy-z, ill add it to sprint, and hopefully will be done within 2 or 3 weeks

mustafaStakater commented 1 year ago

hello @aslafy-z , would it be possible for you to take out time for this and generate a pr with the required changes.

accommodating this in our sprint is looking a little difficult for us.

Thanks

rasheedamir commented 1 year ago

@aslafy-z have you started working on it?

aslafy-z commented 1 year ago

Hey there, I had no time to work on this from now on.

As a first step, we must ensure that all new commits follows conventional commit so we can determine which part of the semver to bump on push to master. If we're OK to squash merge all PRs in this repo, we can use this action that checks the PR titles: https://github.com/aslafy-z/conventional-pr-title-action (disclaimer: I'm the maintainer).

If we want to keep the ability to classic merge PRs, we can use some other like https://github.com/webiny/action-conventional-commits that scans the branch to check each commits names.

Let me know which route you prefer and I will soon open a PR for it.

rasheedamir commented 1 year ago

Sure @aslafy-z we can enforce squash-merge and nice github action! Let's proceed

aslafy-z commented 1 month ago

I had no extra time to work on this subject. I assigned @AsfaMumtaz, he was already on a duplicate issue #318