Closed mustafaStakater closed 1 year ago
@mustafaStakater validation successful`
hmmmm, It creates redundancy in a sense that we can already define the same configuration via paths
value.
I will be removing the else block so that users are forced to define basic paths
value to avoid ambiguity. @d3adb5
@mustafaStakater @d3adb5 I'd prefer to keep it simple and only expose the standard ingress path format as values. I think we can drop servicePort
and serviceName
too. However, if we go that way, it becomes a breaking change, thus, we'll have to bump the major.
We might have usecase for specifying multiple paths. @aslafy-z
By "expose the standard ingress path format as values" I meant expose the whole paths
list in the values as done in this revert. Ok to me.
@mustafaStakater what do you think? should we do major bump?
minor bump looks ok to me, a major bump seems too much
we can merge this
This reverts PR https://github.com/stakater/application/pull/240.