stakater / application

Generic helm chart for all kind of applications
http://stakater.com
MIT License
213 stars 88 forks source link

Revert "Defining default path spec in ingress if hosts.*.paths is null" #247

Closed mustafaStakater closed 1 year ago

mustafaStakater commented 1 year ago

This reverts PR https://github.com/stakater/application/pull/240.

github-actions[bot] commented 1 year ago

@mustafaStakater validation successful`

mustafaStakater commented 1 year ago

hmmmm, It creates redundancy in a sense that we can already define the same configuration via paths value.

I will be removing the else block so that users are forced to define basic paths value to avoid ambiguity. @d3adb5

aslafy-z commented 1 year ago

@mustafaStakater @d3adb5 I'd prefer to keep it simple and only expose the standard ingress path format as values. I think we can drop servicePort and serviceName too. However, if we go that way, it becomes a breaking change, thus, we'll have to bump the major.

mustafaStakater commented 1 year ago

We might have usecase for specifying multiple paths. @aslafy-z

aslafy-z commented 1 year ago

By "expose the standard ingress path format as values" I meant expose the whole paths list in the values as done in this revert. Ok to me.

rasheedamir commented 1 year ago

@mustafaStakater what do you think? should we do major bump?

mustafaStakater commented 1 year ago

minor bump looks ok to me, a major bump seems too much

mustafaStakater commented 1 year ago

we can merge this