stakater / application

Generic helm chart for all kind of applications
http://stakater.com
MIT License
202 stars 85 forks source link

chore: Add missing entries to CHANGELOG.md #248

Closed aslafy-z closed 1 year ago

aslafy-z commented 1 year ago

Add missing entries to CHANGELOG.md

github-actions[bot] commented 1 year ago

@aslafy-z validation successful`

mustafaStakater commented 1 year ago

Ah, i need to look into automatic changelog updates

also , this will cause main pipeline to be triggered because skip-ci might not work according to ref below

If any commit message in your push or the HEAD commit of your PR contains the strings [skip ci], [ci skip], [no ci], [skip actions], or [actions skip] workflows triggered on the push or pull_request events will be skipped. Ref: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

aslafy-z commented 1 year ago

@mustafaStakater This is the job I want to skip: https://github.com/stakater/application/blob/master/.github/workflows/push.yaml#L21. Will this pipeline still triggered?

mustafaStakater commented 1 year ago

yes pipeline will be triggered, for some reason, [skip-ci] in commit message doesnt skip workflows, i wasnt able to investigate it.

aslafy-z commented 1 year ago

Ok. I just updated the commit with 'skip ci' instead of 'skip-ci'

aslafy-z commented 1 year ago

@mustafaStakater it did not work. The release job was executed :(

mustafaStakater commented 1 year ago

yes, this seems weird, gh action supports this , shouldve worked acc to this